Skip to content

Synch Pod-Simple-3.47 into blead #23319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Synch Pod-Simple-3.47 into blead #23319

merged 1 commit into from
Jul 4, 2025

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented May 23, 2025

From Changelog:

3.47 2025-05-15 Karl Williamson khw@cpan.org
- No git-related files in MANIFEST James Keenan++
- Rename method and field to avoid conflicts Graham Knop++
3.46 2025-05-12 Karl Williamson khw@cpan.org
- XHTML: =over without =item should render as a blockquote Graham Knop++
- Add support for underlined text U<> formatting Graham Knop++
- Make 'temp' name checking more succinct Max Maischein++
- github: fix and add tests Lukas Mai++ rwp0++
- Makefile.PL: add missing 'warnings' prereq Lukas Mai++
- Add select method compatible with Pod::Select Graham Knop++
- Modernize htmlbat.t, corpus.t Lukas Mai++, Graham Knop++
- Fix links, typos, acknowledgments James Keenan++ rwp0++, Dan Book++
- Add documentation on sublcassing Graham Knop++
- Fix version checking Philippe Bruhat++
- Fix version number Thibault Duponchelle++
- Use rel2abs instead of abs_path Andrew Fresh++

TODO: fill description here

  • This set of changes requires a perldelta entry, and it is included.
  • This set of changes requires a perldelta entry, and I need help writing it.
  • This set of changes does not require a perldelta entry.

@jkeenan jkeenan requested a review from khwilliamson May 23, 2025 21:45
@jkeenan jkeenan added the defer-next-dev This PR should not be merged yet, but await the next development cycle label May 23, 2025
@jkeenan
Copy link
Contributor Author

jkeenan commented May 23, 2025

I've marked this p.r. "defer-next-dev" because changes in Pod-Simple's functioning are significant enough to have caused test failures in Pod-Html's test suite when I attempted today to synch Pod-Simple-3.47. Those failures will become evident in tests in the smoke-me branch underlying this p.r.

We've encountered this syndrome previously. See: #21311 and #21326.

It's too late in this cycle to start messing around with Pod::Html's ugly test suite, so let's defer bringing this version of Pod-Simple into blead.

@jkeenan jkeenan self-assigned this May 23, 2025
@jkeenan
Copy link
Contributor Author

jkeenan commented May 23, 2025

The relevant test failures in Pod-Html:

$ cd t;TEST_JOBS=1 ./perl harness -v ../ext/Pod-Html/t/htmlview.t ../ext/Pod-Html/t/podnoerr.t ../ext/Pod-Html/t/poderr.t; cd -
../ext/Pod-Html/t/htmlview.t .. 
#   Failed test 'html rendering'
#   at /home/jkeenan/gitwork/perl/ext/Pod-Html/t/lib/Testing.pm line 592.

not ok 1 - html rendering
# --- htmlview_expected.tmp	2025-05-23 17:32:47.276896210 -0400
# +++ /tmp/9pJPlVpRBK/ext/Pod-Html/t/htmlview.html	2025-05-23 17:32:47.275896180 -0400
# @@ -70,7 +70,7 @@
#  
#  <p>The bar item.</p>
#  
# -<ul>
# +<blockquote>
#  
#  <p>This is a list within a list</p>
#  
# @@ -82,7 +82,7 @@
#  
#  <p>The waz item.</p>
#  
# -</ul>
# +</blockquote>
#  
#  </dd>
#  <dt id="baz">baz</dt>
# @@ -219,4 +219,3 @@
#  </html>
#  
#  
# -
1..1
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
../ext/Pod-Html/t/podnoerr.t .. 

#   Failed test 'pod error section'
#   at /home/jkeenan/gitwork/perl/ext/Pod-Html/t/lib/Testing.pm line 592.
not ok 1 - pod error section
# --- podnoerr_expected.tmp	2025-05-23 17:32:47.347898306 -0400
# +++ /tmp/NQT_jGeJay/ext/Pod-Html/t/podnoerr.html	2025-05-23 17:32:47.346898276 -0400
# @@ -19,7 +19,7 @@
#  
#  <p>Test POD ERROR section</p>
#  
# -<ul>
# +<blockquote>
#  
#  <p>This text is not allowed</p>
#  
# @@ -31,7 +31,7 @@
#  
#  <p>The waz item.</p>
#  
# -</ul>
# +</blockquote>
#  
#  
#  </body>
# @@ -39,4 +39,3 @@
#  </html>
#  
#  
# -
1..1
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
../ext/Pod-Html/t/poderr.t .... 
#   Failed test 'pod error section'
#   at /home/jkeenan/gitwork/perl/ext/Pod-Html/t/lib/Testing.pm line 592.

not ok 1 - pod error section
# --- poderr_expected.tmp	2025-05-23 17:32:47.420900461 -0400
# +++ /tmp/yR0Px0_M3G/ext/Pod-Html/t/poderr.html	2025-05-23 17:32:47.419900431 -0400
# @@ -20,7 +20,7 @@
#  
#  <p>Test POD ERROR section</p>
#  
# -<ul>
# +<blockquote>
#  
#  <p>This text is not allowed</p>
#  
# @@ -32,7 +32,7 @@
#  
#  <p>The waz item.</p>
#  
# -</ul>
# +</blockquote>
#  
#  <h1 id="POD-ERRORS">POD ERRORS</h1>
#  
# @@ -54,4 +54,3 @@
#  </html>
#  
#  
# -
1..1
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
../ext/Pod-Html/t/htmlview.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
../ext/Pod-Html/t/podnoerr.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
../ext/Pod-Html/t/poderr.t  (Wstat: 256 (exited 1) Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=3, Tests=3,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.16 cusr  0.05 csys =  0.22 CPU)
Result: FAIL
Finished test run at Fri May 23 17:32:47 2025.

@khwilliamson khwilliamson removed the defer-next-dev This PR should not be merged yet, but await the next development cycle label Jul 4, 2025
@khwilliamson khwilliamson force-pushed the smoke-me/jkeenan/sync-pod-simple-20250523 branch from 9d0f651 to dd3f48f Compare July 4, 2025 03:22
@khwilliamson @jkeenan
Synch Pod-Simple-3.47 into blead; accommodate Pod-Html tests
5c64980 
From Pod-Simple's Changelog:

3.47 2025-05-15 Karl Williamson <khw@cpan.org>
        - No git-related files in MANIFEST  James Keenan++
        - Rename method and field to avoid conflicts  Graham Knop++
3.46 2025-05-12 Karl Williamson <khw@cpan.org>
        - XHTML: =over without =item should render as a blockquote Graham Knop++
        - Add support for underlined text U<> formatting Graham Knop++
        - Make 'temp' name checking more succinct Max Maischein++
        - github: fix and add tests  Lukas Mai++  rwp0++
        - Makefile.PL: add missing 'warnings' prereq  Lukas Mai++
        - Add select method compatible with Pod::Select  Graham Knop++
        - Modernize htmlbat.t, corpus.t  Lukas Mai++, Graham Knop++
        - Fix links, typos, acknowledgments  James Keenan++ rwp0++, Dan Book++
        - Add documentation on sublcassing  Graham Knop++
        - Fix version checking  Philippe Bruhat++
        - Fix version number  Thibault Duponchelle++
        - Use rel2abs instead of abs_path  Andrew Fresh++

Committer:

Update our expected pod2html output to reflect changes in Pod-Simple
being synched into Perl 5 core subsequent to v5.43.0 tag.
@jkeenan jkeenan force-pushed the smoke-me/jkeenan/sync-pod-simple-20250523 branch from 32c523c to 5c64980 Compare July 4, 2025 12:53
@jkeenan
Copy link
Contributor Author

jkeenan commented Jul 4, 2025

Tests in ext/Pod-Html/t have been updated to reflect new expectations as of Pod-Simple-3.47. smoke-me branch squashed and re-pushed. Please review.

@jkeenan jkeenan merged commit 9087431 into blead Jul 4, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khwilliamson khwilliamson khwilliamson approved these changes

@thibaultduponchelle thibaultduponchelle thibaultduponchelle approved these changes

Assignees

@jkeenan jkeenan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkeenan @khwilliamson @thibaultduponchelle